Skip to content

Conversation

@chengfang
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.81%. Comparing base (7f93ac5) to head (8b54ac8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   61.72%   62.81%   +1.09%     
==========================================
  Files          31       31              
  Lines        3117     3117              
==========================================
+ Hits         1924     1958      +34     
+ Misses       1049     1015      -34     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengfang chengfang force-pushed the options.metrics.tests branch from 4daf178 to 8b54ac8 Compare July 5, 2024 22:22
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis changed the title add unit tests for pkg/options.go and pkg/metrics.go tests: add unit tests for pkg/options.go and pkg/metrics.go Jul 5, 2024
@jannfis jannfis merged commit 3e7dc57 into argoproj-labs:master Jul 5, 2024
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants