Skip to content

Conversation

@benfuu
Copy link
Contributor

@benfuu benfuu commented Jun 23, 2024

Pass the git store from the write back config to the git credential functions.

Fixes:

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.16%. Comparing base (38c82f3) to head (1210c77).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #756   +/-   ##
=======================================
  Coverage   56.16%   56.16%           
=======================================
  Files          31       31           
  Lines        3105     3105           
=======================================
  Hits         1744     1744           
  Misses       1222     1222           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengfang
Copy link
Collaborator

@benfuu thanks for the contribution. Can you rebase to pull in the latest changes, and fix the DCO check failure?

Fixing the DCO in this PR should be as simple as running

git commit --amend -s

in your local PR branch and then force-pushing.

@benfuu
Copy link
Contributor Author

benfuu commented Jun 24, 2024

@benfuu thanks for the contribution. Can you rebase to pull in the latest changes, and fix the DCO check failure?

Fixing the DCO in this PR should be as simple as running

git commit --amend -s

in your local PR branch and then force-pushing.

sure, done!

@chengfang chengfang merged commit 9ad9e4f into argoproj-labs:master Jun 24, 2024
@chengfang
Copy link
Collaborator

Thanks @benfuu !

@benfuu benfuu deleted the fix/git-creds branch June 24, 2024 03:50
@benfuu benfuu mentioned this pull request Jun 24, 2024
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants