fix: Make Git credentials work again #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| case strings.HasPrefix(os.Args[1], "Username"): | ||
| fmt.Println(creds.Username) | ||
| case strings.HasPrefix(os.Args[1], "Password"): | ||
| fmt.Println(creds.Password) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
Signed-off-by: jannfis <[email protected]>
Collaborator
|
@jannfis will go over it tomorrow |
chengfang
approved these changes
Jun 14, 2024
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
* fix: Make Git credentials work again Signed-off-by: jannfis <[email protected]> * Update Signed-off-by: jannfis <[email protected]> --------- Signed-off-by: jannfis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the Git askpass helper that Argo CD's Git client uses in the meanwhile.
This PR includes some dirty workaounds that should be temporary (see code comments).
Fixes #735
Fixes #728