fix: invalid memory address due to store is nil in gitcreds.go #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pasha Kostohrys <[email protected]>
jannfis
requested changes
May 27, 2024
Contributor
jannfis
left a comment
jannfis
left a comment
There was a problem hiding this comment.
I believe we need to update the Git client in ext/git first.
jannfis
approved these changes
May 27, 2024
Contributor
jannfis
left a comment
jannfis
left a comment
There was a problem hiding this comment.
As discussed with @pasha-codefresh, this seems to unblock most people.
Update of ext/git will be targeted for 0.14
LGTM.
Collaborator
Author
|
@jannfis it is not crashing anymore ( master branch it is another issue ) |
Collaborator
Author
|
pasha-codefresh
added a commit
that referenced
this pull request
May 27, 2024
Signed-off-by: Pasha Kostohrys <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Pasha Kostohrys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #621