Fix: golangci lint #707
Merged
Fix: golangci lint #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengfang
reviewed
May 3, 2024
chengfang
reviewed
May 3, 2024
0luwaj0x1
force-pushed
the
fix-golangci-lint
branch
from
0fbfb3a to
206de6d
Compare
chengfang
reviewed
May 7, 2024
Dockerfile
Outdated
| apk add ca-certificates git openssh-client python3 py3-pip tini && \ | ||
| apk add --no-cache ca-certificates git openssh-client python3 py3-pip tini && \ | ||
| python3 -m venv /venv && \ | ||
| . /venv/bin/activate && \ |
There was a problem hiding this comment.
#700 already has a fix for the above problem in Dockerfile. I think we should treat this as a separate issue to be addressed by #700. If you agree, can you please undo this change in Dockerfile, and keep this PR for fixing lint? @0luwaj0x1
|
@0luwaj0x1 can you also squash all commits? |
Signed-off-by: Josiah Ilesanmi <[email protected]>
0luwaj0x1
force-pushed
the
fix-golangci-lint
branch
from
206de6d to
82b5f6b
Compare
chengfang
approved these changes
May 7, 2024
|
Thanks @0luwaj0x1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #706