Skip to content

Conversation

@seanmorton
Copy link
Contributor

For those using Applications in any namespace, the docs should mention that Image Updater is not compatible with any Application resources installed in namespaces other than argocd.

@ElanHasson
Copy link

That is unfortunate. This is exactly what I'm doing and I just installed and deployed it :D

@ElanHasson
Copy link

This is a dupe of #601 and #612 cover this.

Copy link

@JStacy86 JStacy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should absolutely be added. It completely got me.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.16%. Comparing base (fc1999f) to head (77146fe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   56.16%   56.16%           
=======================================
  Files          31       31           
  Lines        3105     3105           
=======================================
  Hits         1744     1744           
  Misses       1222     1222           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seanmorton seanmorton force-pushed the sean/update-docs-ns branch from d828c11 to 1e0bdb5 Compare June 26, 2024 17:13
@seanmorton
Copy link
Contributor Author

seanmorton commented Jun 26, 2024

Looks like most recent effort to add support for this was closed: #672

Could we merge this warning so folks are at least aware? My latest change also adds a brief warning about this to the documentation root.

@seanmorton seanmorton force-pushed the sean/update-docs-ns branch from 1e0bdb5 to 77146fe Compare June 26, 2024 19:05
@seanmorton seanmorton force-pushed the sean/update-docs-ns branch from 77146fe to 19b3855 Compare June 26, 2024 19:10
@chengfang chengfang merged commit c9ed948 into argoproj-labs:master Jun 26, 2024
@chengfang
Copy link
Collaborator

Thanks @seanmorton @ElanHasson @JStacy86 for the fix and review!

@mcanevet
Copy link

Hasn't #687 added the support of Applications in any Namespace?

@chengfang
Copy link
Collaborator

@mcanevet thanks for pointing that out. @seanmorton @ElanHasson @JStacy86 could you please verify if the current master branch works for you when using image-updater for apps in any namespace?

@wd
Copy link
Contributor

wd commented Jul 30, 2024

I can confirm the image-updater can work with apps in any namespace if you use the APPLICATIONS_API approach.
#601 (comment)

sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
@ElanHasson
Copy link

Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants