docs: Added warning about existing tag in semver #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kostis Kapelonis <[email protected]>
jannfis
approved these changes
Nov 16, 2022
Contributor
jannfis
left a comment
jannfis
left a comment
There was a problem hiding this comment.
LGTM! Thanks and sorry for the late reaction
mcfearsome
pushed a commit
to mcfearsome/argocd-image-updater
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]>
dlactin
pushed a commit
to dlactin/argocd-image-updater
that referenced
this pull request
May 9, 2024
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kostis Kapelonis [email protected]
When changing from latest to semver strategy, users must be careful and make sure that the existing
tag is already following semver
Otherwise trying to change from tag "rc1" to "1.0" or something similar doesn't work