Skip to content

feat: Improve visibility for skipped apps #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

feat: Improve visibility for skipped apps #344

merged 1 commit into from
Jan 12, 2022

Conversation

@jannfis
Copy link
Contributor

@jannfis jannfis commented Jan 12, 2022

This PR improves visibility on why a given app is skipped:

  1. Move checks for app type and name matching after we found out that its correctly annotated
  2. Issue a warning message instead of a trace message if the application has not the correct type
  3. If an application doesn't match a name pattern, issue a debug message instead of a trace message

Signed-off-by: jannfis [email protected]

@jannfis jannfis merged commit c5889a2 into argoproj-labs:master Jan 12, 2022
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
@jannfis @sribiere-jellysmack
feat: Improve visibility for skipped apps (argoproj-labs#344)
846dff5 
Signed-off-by: jannfis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jannfis