Skip to content

Conversation

@jannfis
Copy link
Contributor

@jannfis jannfis commented Oct 26, 2021

This updates the Git client to the version from Argo CD v2.1.5

Should pull in a couple of enhancements, and also the possibility to use GitHub app authentication for repository interaction.

Signed-off-by: jannfis [email protected]

@jannfis jannfis merged commit a03f319 into argoproj-labs:master Oct 26, 2021
@timothyjlaurent
Copy link

I don't think this works. The GitHubAppCreds are never returned from this function https://github.com/jannfis/argocd-image-updater/blob/972500fc657f5980915f07317f963b4b091e4ff7/pkg/argocd/gitcreds.go#L49

@timothyjlaurent
Copy link

Likely related to #613

sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants