fix: use distribution to parse references #275
Conversation
fixes #273
| img := ContainerImage{} | ||
| img.RegistryURL = reference.Domain(parsed) | ||
| // remove default registry for backwards-compatibility | ||
| if img.RegistryURL == "docker.io" && !strings.HasPrefix(imgRef, "docker.io") { |
There was a problem hiding this comment.
@jannfis this was my workaround. If docker.io was explicity the registry, retain it, else remove it. Is there a case I’m missing?
There was a problem hiding this comment.
Ah, now I got it. Sorry, I was a little confused and missed the check for the prefix on original image ref.
OK, so if the parsed registry domain is docker.io, but the original image ref is not prefixed with docker.io, we assume default registry and set it to blank. Yes, that makes sense and would restore original behavior. Thanks for clarifying it.
|
OK, so I think the last remaining issue is that This is currently also a per-registry configurable in the image updater (see https://argocd-image-updater.readthedocs.io/en/stable/configuration/registries/#configuring-a-custom-container-registry, |
Done. |
* fix: use distribution to parse references fixes argoproj-labs#273 * fix: keep docker.io if it was specified * fix: remove library/ if it was added
2 participants
fixes #273