Skip to content

Conversation

@jannfis
Copy link
Contributor

@jannfis jannfis commented Jun 18, 2021

Do not return the original tag if no tag found in a repository was considered for being upgradeable to.

This fixes a scenario with digest update strategy, where a tag to track was specified as constraint but did not exist in the registry. This led to an update of the image to the (non-existing) tag, instead of just ignoring it.

Fixes #217

Signed-off-by: jannfis [email protected]

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #219 (885ed0b) into master (1d19e6a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   66.77%   66.75%   -0.03%     
==========================================
  Files          20       20              
  Lines        1574     1573       -1     
==========================================
- Hits         1051     1050       -1     
  Misses        424      424              
  Partials       99       99              
Impacted Files Coverage Δ
pkg/image/version.go 61.40% <100.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d19e6a...885ed0b. Read the comment docs.

@jannfis jannfis merged commit 4e88c62 into argoproj-labs:master Jun 18, 2021
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update-strategy digest fails with amazon ECR api?

1 participant