-
Notifications
You must be signed in to change notification settings - Fork 313
feat(manifests): add ssh volume mounts and volume #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manifests): add ssh volume mounts and volume #212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 66.77% 66.77%
=======================================
Files 20 20
Lines 1574 1574
=======================================
Hits 1051 1051
Misses 424 424
Partials 99 99 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @spoukke and sorry for the late review.
I feel this mount should be marked as optional, because there will be scenarios where this CM does not exist (e.g. user installs the image updater outside argocd namespace). Can you please change it so it's an optional mount? Thanks.
Hi @jannfis ! No worries. The change is done, let me know if there is anything else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @spoukke !
* feat(manifests): add ssh volume mounts and volume * feat(ssh-volume): add optionnal mount
The default behavior of image updater is to use argocd credentials. If it is setup with ssh, this volume mounts and volume are needed in order for image updater to be able to commit to the repository