fix: Prevent update loop with git write-back #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 68.21% 68.20% -0.01%
==========================================
Files 19 19
Lines 1337 1343 +6
==========================================
+ Hits 912 916 +4
- Misses 343 344 +1
- Partials 82 83 +1
Continue to review full report at Codecov.
|
jannfis
added a commit
that referenced
this pull request
Mar 25, 2021
Signed-off-by: jannfis <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
Signed-off-by: jannfis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jannfis [email protected]
This will hopefully fix #170.
Prevent an update loop with Git write-back when not all of the images needed update by including also the non-updated images in the list of images to update.