Skip to content

Conversation

@chengfang
Copy link
Collaborator

@chengfang chengfang commented Oct 31, 2025

Fixes #974

When writing updates to helm values file in git repo, image updater checks the image-name format in the target helm values file: if it's short (e.g., org/image), or long (e.g., docker.io/org/image). If the original image-name is short format, then image updater converts the full image name to short one before writing it out.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 85.29412% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.26%. Comparing base (8c42fca) to head (6e1d5a0).

Files with missing lines Patch % Lines
pkg/argocd/update.go 83.92% 5 Missing and 4 partials ⚠️
registry-scanner/pkg/image/image.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           master-annotation-based    #1312      +/-   ##
===========================================================
+ Coverage                    72.06%   72.26%   +0.19%     
===========================================================
  Files                           45       45              
  Lines                         4189     4255      +66     
===========================================================
+ Hits                          3019     3075      +56     
- Misses                        1005     1011       +6     
- Partials                       165      169       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dkarpele dkarpele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to add tests to Test_MarshalParamsOverride from update_test.go. The change to marshalParamsOverride is quite significant.

… image names are converted to short form when needed

Signed-off-by: Cheng Fang <[email protected]>
@chengfang chengfang merged commit 5ed9f6d into argoproj-labs:master-annotation-based Nov 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants