Skip to content

Conversation

@chengfang
Copy link
Collaborator

when image name contains the registryURL, calling GetFullNameWithTag and GetFullNameWithoutTag func produces malformed full image name (e.g., image: docker.io/docker.io/bitnamilegacy/nginx:1.27.5), which causes the pod to fail to start.

…g and GetFullNameWithTag func

Signed-off-by: Cheng Fang <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.06%. Comparing base (5bc368c) to head (b11cba3).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           master-annotation-based    #1310      +/-   ##
===========================================================
+ Coverage                    72.05%   72.06%   +0.01%     
===========================================================
  Files                           45       45              
  Lines                         4187     4189       +2     
===========================================================
+ Hits                          3017     3019       +2     
  Misses                        1005     1005              
  Partials                       165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chengfang chengfang merged commit 8c42fca into argoproj-labs:master-annotation-based Oct 31, 2025
11 checks passed
chengfang added a commit to chengfang/argocd-image-updater that referenced this pull request Nov 3, 2025
chengfang added a commit that referenced this pull request Nov 3, 2025
…g and GetFullNameWithTag func (#1310) (#1318)

Signed-off-by: Cheng Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants