Skip to content

Conversation

@dkarpele
Copy link
Collaborator

Add deprecation comments to functions, structs, constants, and flags that were removed in the CRD branch to notify users of upcoming breaking changes.

  • Add deprecation notices to annotation-based functions in options.go
  • Add deprecation notices to annotation-related constants in constants.go and helper.go
  • Add deprecation notices to native ArgoCD client struct and methods in argocd.go
  • Add deprecation notices to removed CLI flags in run.go

These deprecation warnings inform users that the CRD branch introduces a
new architecture that eliminates the need for annotation-based approaches
and native ArgoCD client configurations.

…lity

Add deprecation comments to functions, structs, constants, and flags that
were removed in the CRD branch to notify users of upcoming breaking changes.

Signed-off-by: Denis Karpelevich <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.64%. Comparing base (cc9f71b) to head (d4088c5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
+ Coverage   63.52%   63.64%   +0.12%     
==========================================
  Files          23       23              
  Lines        3191     3202      +11     
==========================================
+ Hits         2027     2038      +11     
  Misses       1054     1054              
  Partials      110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cmd/run.go Outdated
},
}

// DEPRECATED: These flags have been removed in the CRD branch and will be deprecated in a future release.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we say '.. will be deprecated and removed in a future release' (to emphasize removal)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for affected cli flags, can we also add a short warning message to the description field, something like: https://github.com/argoproj/argo-cd/blob/master/server/cache/cache.go#L40 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also plan to add similar deprecation message to affected docs files?

Copy link
Collaborator Author

@dkarpele dkarpele Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
all comments were addressed

Signed-off-by: Denis Karpelevich <[email protected]>
@chengfang chengfang merged commit 375346e into argoproj-labs:master Aug 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants