-
Notifications
You must be signed in to change notification settings - Fork 313
chore(crd): add deprecation warnings for CRD branch removed functionality #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lity Add deprecation comments to functions, structs, constants, and flags that were removed in the CRD branch to notify users of upcoming breaking changes. Signed-off-by: Denis Karpelevich <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1223 +/- ##
==========================================
+ Coverage 63.52% 63.64% +0.12%
==========================================
Files 23 23
Lines 3191 3202 +11
==========================================
+ Hits 2027 2038 +11
Misses 1054 1054
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmd/run.go
Outdated
| }, | ||
| } | ||
|
|
||
| // DEPRECATED: These flags have been removed in the CRD branch and will be deprecated in a future release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we say '.. will be deprecated and removed in a future release' (to emphasize removal)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for affected cli flags, can we also add a short warning message to the description field, something like: https://github.com/argoproj/argo-cd/blob/master/server/cache/cache.go#L40 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also plan to add similar deprecation message to affected docs files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
all comments were addressed
Signed-off-by: Denis Karpelevich <[email protected]>
Add deprecation comments to functions, structs, constants, and flags that were removed in the CRD branch to notify users of upcoming breaking changes.
These deprecation warnings inform users that the CRD branch introduces a
new architecture that eliminates the need for annotation-based approaches
and native ArgoCD client configurations.