Skip to content

Conversation

@cjcocokrisp
Copy link
Contributor

Adds documentation for the webhook feature.

Changes:

  • Updates the run page with new webhook related flags
  • Adds the documentation for webhook command
  • Adds a configuration page with information about configuring the webhook
  • Removed some flags that I realized were not used from the run command

…related flags to run command docs

Signed-off-by: Christopher Coco <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.05%. Comparing base (7ef756e) to head (30a5f08).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1207      +/-   ##
==========================================
- Coverage   63.08%   63.05%   -0.03%     
==========================================
  Files          23       23              
  Lines        3142     3140       -2     
==========================================
- Hits         1982     1980       -2     
  Misses       1050     1050              
  Partials      110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Christopher Coco <[email protected]>
@cjcocokrisp
Copy link
Contributor Author

Altered the example url to be app1.example.com.

@chengfang
Copy link
Collaborator

all the new command flags can also be specified via env var, and we may want to document this capability too.

@chengfang
Copy link
Collaborator

How about also include a sample webhook event payload?

During your testing, have you seen issues with not receiving expected events due to various configuration such as unmatched secret, incorrect port, etc? If so, can you also include them in a troubleshooting section?

@cjcocokrisp
Copy link
Contributor Author

How about also include a sample webhook event payload?

During your testing, have you seen issues with not receiving expected events due to various configuration such as unmatched secret, incorrect port, etc? If so, can you also include them in a troubleshooting section?

Yeah sure I can add a sample webhook event payload. The payloads vary from each of the container registries so do you think having an example specifically shown would be good or just links to the documentation for each of the registries would be suffice?

For troubleshooting, I can definitely add a section that shows errors that you might receive as well.

@chengfang
Copy link
Collaborator

having an example specifically shown would be good or just links to the documentation for each of the registries would be suffice?

links should suffice; if links not available, then include a sample payload from one of the registries will be good too.

@cjcocokrisp
Copy link
Contributor Author

Added those two sections. Let me know what you think.

@chengfang chengfang merged commit 18767ed into argoproj-labs:master Aug 6, 2025
11 checks passed
@cjcocokrisp cjcocokrisp deleted the docs/webhook branch August 7, 2025 15:30
chansuke pushed a commit to chansuke/argocd-image-updater that referenced this pull request Aug 9, 2025
dkarpele pushed a commit to dkarpele/argocd-image-updater that referenced this pull request Aug 10, 2025
)

Signed-off-by: Christopher Coco <[email protected]>
(cherry picked from commit 18767ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants