manifests(webhook): expose webhook feature #1198
Conversation
…lter deployment env spec to add new cil flags Signed-off-by: Christopher Coco <[email protected]> remove flags for health and metrics in webhook server Signed-off-by: Christopher Coco <[email protected]>
cjcocokrisp
requested review from
chengfang,
ishitasequeira,
jannfis and
pasha-codefresh
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
- Coverage 63.10% 63.08% -0.03%
==========================================
Files 23 23
Lines 3144 3142 -2
==========================================
- Hits 1984 1982 -2
Misses 1050 1050
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
so with this PR, the new image-updater and service and ingress will always be installed after applying the install manifest file, either if the users do not enable it? How about not including them in the install, but providing the service and ingress manifests as a reference? |
…cd-image-updater-secret Signed-off-by: Christopher Coco <[email protected]> make manifests Signed-off-by: Christopher Coco <[email protected]>
cjcocokrisp
force-pushed
the
manifests/webhook
branch
from
e2aaf7a to
f4d20ed
Compare
Yeah I think this would be a good idea. So should they just be removed from the base |
Signed-off-by: Christopher Coco <[email protected]>
|
yes. |
Signed-off-by: Christopher Coco <[email protected]>
Signed-off-by: Christopher Coco <[email protected]> (cherry picked from commit 9fc3c14)
3 participants
Adds the Kubernetes manifests to expose the webhook feature. Created a service and ingress to expose the webhook server. Environment variables for CLI command flags related to the feature have been added to the container spec in the deployment as well.
One other thing I noticed while testing the manifests was that when using the webhook command the health port was different so it would show up as failed within the cluster. So in the webhook command I realized I never actually set up the health and metrics server due to the webhook server having a health endpoint. So I removed the command flags for that in the webhook command.