-
Notifications
You must be signed in to change notification settings - Fork 313
feat(webhook): add webhook handler for quay.io and make improvements to the community PR #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chengfang
merged 4 commits into
argoproj-labs:master
from
cjcocokrisp:feat/webhook-quay
Jul 31, 2025
Merged
feat(webhook): add webhook handler for quay.io and make improvements to the community PR #1197
chengfang
merged 4 commits into
argoproj-labs:master
from
cjcocokrisp:feat/webhook-quay
Jul 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Coco <[email protected]> fix issue with server.go Signed-off-by: Christopher Coco <[email protected]>
Signed-off-by: Christopher Coco <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
==========================================
- Coverage 64.14% 63.10% -1.05%
==========================================
Files 22 23 +1
Lines 2990 3144 +154
==========================================
+ Hits 1918 1984 +66
- Misses 962 1050 +88
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… with the git writeback method and making the webhook command more inline with the run command Signed-off-by: Christopher Coco <[email protected]> fix lint Signed-off-by: Christopher Coco <[email protected]>
87e0889 to
dfc1ed1
Compare
chengfang
reviewed
Jul 30, 2025
Signed-off-by: Christopher Coco <[email protected]>
|
Resolved feedback and added a comment above the quay payload with link to Quay docs on webhook events. |
chengfang
approved these changes
Jul 31, 2025
dkarpele
pushed a commit
to dkarpele/argocd-image-updater
that referenced
this pull request
Aug 10, 2025
…to the community PR (argoproj-labs#1197) Signed-off-by: Christopher Coco <[email protected]> (cherry picked from commit fa2de9b) Signed-off-by: Denis Karpelevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a Quay webhook processor to the webhook feature for Image Updater. This is accomplished by using the handler model that is used in the implementation. The handler is added along with the unit tests for it.
On top of adding the webhook handler for quay, there is also some other enhancements to the feature in this PR. The list is below.
Enhancements:
Secrets Changes:
The original implementation has this scheme to validate the Docker webhooks:
This scheme does not actually happen with Docker. Docker does not have that sort of scheme and the only registry that I found that has that is GitHub. Docker and Quay both in fact do not have any type of secrets and signatures built into their webhooks. This issue that is open in the Docker roadmap mentions this and it is still open and people are still asking with the last reply being in June of this year.
One thing I did to combat this issue of Docker and Quay not having secrets is add in a way that secrets could kind of be added. The way this is done by using the query parameter
secretto hold what would be the secret. This is not the most secure thing and is more or less just there to be there. When I go and write the docs I plan to denote how this is not the most secure thing so don't use a secret that is shared with something else for this scheme. Let me know what you think about this.