Add helpers to return a new context.Context that carries the provided logrus Entry.
#1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logrus Entry. Thanks to them, we can pass a contextual logger down through a call stack: `controller=ctrl controllerGroup=ctrlG controllerKind=ctrlK logger=lgr` Signed-off-by: Denis Karpelevich <[email protected]>
dkarpele
requested review from
chengfang,
ishitasequeira,
jannfis and
pasha-codefresh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
=======================================
Coverage 63.34% 63.34%
=======================================
Files 15 15
Lines 2357 2357
=======================================
Hits 1493 1493
Misses 769 769
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chengfang
approved these changes
Jun 24, 2025
cjcocokrisp
pushed a commit
to cjcocokrisp/argocd-image-updater
that referenced
this pull request
Jul 9, 2025
…ed logrus Entry. (argoproj-labs#1171) Signed-off-by: Denis Karpelevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to them, we can pass a contextual logger down through a call stack:
controller=ctrl controllerGroup=ctrlG controllerKind=ctrlK logger=lgr.Will be used in future CRD feature. See #1170