Skip to content

Conversation

@chansuke
Copy link
Contributor

@chansuke chansuke commented Jun 8, 2025

Both functions yield the same empty, never-cancelled context, using context.Background() clarifies intent:

  • context.Background() clearly conveys that the call is rooted at a top-level context that is never cancelled or timed-out
  • new contributors no longer wonder whether cancellation was forgotten; they see an explicit, canonical root context everywhere

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.27%. Comparing base (daf5543) to head (f63301d).

Files with missing lines Patch % Lines
cmd/run.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   63.27%   63.27%           
=======================================
  Files          15       15           
  Lines        2358     2358           
=======================================
  Hits         1492     1492           
  Misses        771      771           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chansuke chansuke marked this pull request as ready for review June 9, 2025 06:48
@chengfang
Copy link
Collaborator

@chansuke can you describe why the changes are needed in the description section?

@chansuke
Copy link
Contributor Author

chansuke commented Jul 5, 2025

@chengfang
Thank you so much for your commend and sorry for the late reply. I updated the description.

@chengfang chengfang merged commit 6b42617 into argoproj-labs:master Jul 15, 2025
11 checks passed
cjcocokrisp pushed a commit to cjcocokrisp/argocd-image-updater that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants