Skip to content

Conversation

@chansuke
Copy link
Contributor

Refactor global metric initialization.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2025

Codecov Report

Attention: Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.34%. Comparing base (1dfab3e) to head (082ed87).

Files with missing lines Patch % Lines
pkg/metrics/metrics.go 55.00% 6 Missing and 3 partials ⚠️
cmd/run.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
- Coverage   63.60%   63.34%   -0.27%     
==========================================
  Files          15       15              
  Lines        2341     2357      +16     
==========================================
+ Hits         1489     1493       +4     
- Misses        760      769       +9     
- Partials       92       95       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chengfang
Copy link
Collaborator

chengfang commented May 21, 2025

@chansuke thanks for the contribution. Can you add description to this PR, including the rational for the change, etc?

Also can you fix the DCO check failure?

@chansuke chansuke force-pushed the refactor/global-init branch from 5931661 to 16973e8 Compare May 23, 2025 12:05
@chengfang chengfang merged commit c89b8f7 into argoproj-labs:master May 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants