feat: Add GetDurationVal to handle optional duration config from env #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new utility function `GetDurationVal` to retrieve a time.Duration from an environment variable, with a default value fallback and error logging. Signed-off-by: Denis Karpelevich <[email protected]>
dkarpele
requested review from
chengfang,
ishitasequeira,
jannfis and
pasha-codefresh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1110 +/- ##
=======================================
Coverage 63.49% 63.49%
=======================================
Files 15 15
Lines 2326 2326
=======================================
Hits 1477 1477
Misses 758 758
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chengfang
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new utility function
GetDurationValto retrieve a time.Duration from an environment variable, with a default value fallback and error logging.