Skip to content

Conversation

@wd
Copy link
Contributor

@wd wd commented Apr 11, 2025

Fix #1098

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (a35ad14) to head (b4be651).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1101   +/-   ##
=======================================
  Coverage   63.49%   63.49%           
=======================================
  Files          15       15           
  Lines        2326     2326           
=======================================
  Hits         1477     1477           
  Misses        758      758           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wd
Copy link
Contributor Author

wd commented Apr 14, 2025

Thank you. It looks like someone needs to click the merge button. I don't see it on my side.

@chengfang chengfang merged commit 11abcc8 into argoproj-labs:master Apr 14, 2025
11 checks passed
@chengfang
Copy link
Collaborator

We may need to port this fix to registry-scanner release-0.1 branch, if we decide to release registry-scanner v0.1.1 (next patch release). And update image-updater (master and/or release-0.16) to reference the fixed registry-scanner version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is a regression when moved 'pkg/log' to 'registry-scanner/pkg/log'

4 participants