Skip to content

Conversation

@aali309
Copy link
Contributor

@aali309 aali309 commented Mar 26, 2025

This change upgrades k8s.io/kubernetes v1.31.0 to k8s.io/kubernetes to v1.32.2

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (11abcc8) to head (b784efe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   63.49%   63.49%           
=======================================
  Files          15       15           
  Lines        2326     2326           
=======================================
  Hits         1477     1477           
  Misses        758      758           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chengfang
Copy link
Collaborator

can you describe the steps you did to upgrade it?

@aali309
Copy link
Contributor Author

aali309 commented Mar 26, 2025

can you describe the steps you did to upgrade it?

manually upgraded k8s.io/kubernetes to v1.32.2, the likes of k8s.io/kubectl to v0.32.2 // indirect
and all on the replace section to v0.32.2
then I run go mod tidy and go mod vendor

@chengfang
Copy link
Collaborator

registry-scanner sub-module also contains some k8s.io deps and should also be kept in sync.

@chengfang
Copy link
Collaborator

LGTM, but we may need to hold it off until 0.16.0 is released, since this is a minor-version upgrade of a big library.

@chengfang chengfang merged commit 7a3b75a into argoproj-labs:master Apr 17, 2025
15 of 17 checks passed
@aali309 aali309 deleted the upgradek8sIO branch April 17, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants