docs: fix text overflow issue in admonition block #1041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ta8i2chi8
requested review from
chengfang,
ishitasequeira,
jannfis and
pasha-codefresh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
=======================================
Coverage 62.59% 62.59%
=======================================
Files 15 15
Lines 2259 2259
=======================================
Hits 1414 1414
Misses 755 755
Partials 90 90 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Taichi Morimoto <[email protected]>
Collaborator
|
Thanks @ta8i2chi8 for the PR. Looks like this has been fixed in the latest docs (note: the links contains https://argocd-image-updater.readthedocs.io/en/latest/install/installation/#apply-the-manifests See previous PR #983 |
Author
|
Thank you for your response @chengfang ! I'll go ahead and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a text overflow issue in admonition blocks (e.g., !!! warning) in the documentation.
As an additional note, this issue was not present in the local environment (tested using
make serve-docs) but appeared on the deployed page.I am not sure if the issue is resolved on the deployed page.
What is the best way to check it?
Looking forward to your review 🙏
Thank you!