Skip to content

Conversation

@chengfang
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.42%. Comparing base (ae473dd) to head (09de53c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1007   +/-   ##
=======================================
  Coverage   63.42%   63.42%           
=======================================
  Files          15       15           
  Lines        2212     2212           
=======================================
  Hits         1403     1403           
  Misses        723      723           
  Partials       86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was asking myself whether we should use a local reference in replace rules?

@chengfang
Copy link
Collaborator Author

Towards the end of go.mod, there is a commented replacing line to be used for local testing.

argocd-image-updater/go.mod

Lines 176 to 177 in ae473dd

// Uncomment for local testing
// github.com/argoproj-labs/argocd-image-updater/registry-scanner => ./registry-scanner/

@chengfang chengfang merged commit b155506 into argoproj-labs:master Jan 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants