feat - Add option to provide resources requests/limits to controller #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jgwest , |
OpenGuidou
force-pushed
the
resources
branch
2 times, most recently
from
54ed938 to
e0c5c5e
Compare
|
Hi @jgwest , can I get a review here ? |
OpenGuidou
force-pushed
the
resources
branch
2 times, most recently
from
6483690 to
7eeb4af
Compare
Signed-off-by: Guillaume Doussin <[email protected]>
Signed-off-by: Jonathan West <[email protected]>
jgwest
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Looks great, thanks @OpenGuidou! I made some additional tweaks to the unit/E2E tests (probably overkill 😄 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #59