Skip to content

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Apr 10, 2024

What does this PR do / why we need it:

  • Use argoproj-labs/openshift as the value we set in the Argo Rollouts ConfigMap, to enable OpenShift Route Traffic Management plugin
  • Update to latest commit of openshift route plugin
  • Add OpenShift Route to kubebuilder tags, and to the Role/ClusterRole that will be generated for RolloutsManager install
  • Regenerate config YAML
  • Covered by existing unit/E2E tests.

Have you updated the necessary documentation?

  • Documentation update is required by this PR, and has been updated.

Which issue(s) this PR fixes:
N/A

How to test changes / Special notes to the reviewer:

@jgwest jgwest marked this pull request as ready for review April 10, 2024 09:47
Copy link
Collaborator

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jgwest jgwest merged commit efd9a78 into argoproj-labs:main Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants