Skip to content

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Feb 27, 2024

What does this PR do / why we need it:

  • Improve upstream Rollouts E2E test parsing: replace the simple bash-based parsing with a short Go script.
  • The previous version of the code would just ignore retries.
  • The new version will allow parsing of retries, and will report a failure only if a test never succeeds (after 5 retries)

Have you updated the necessary documentation?

  • Documentation update is required by this PR, and has been updated.

Which issue(s) this PR fixes:
N/A

@jgwest jgwest force-pushed the improve-rollouts-e2e-test-parsing-feb-2024 branch 3 times, most recently from c908574 to 2f99e58 Compare February 27, 2024 19:07
@jgwest jgwest force-pushed the improve-rollouts-e2e-test-parsing-feb-2024 branch from 2f99e58 to df3dce2 Compare February 27, 2024 19:41
Copy link
Collaborator

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go script looks good @jgwest.

@chetan-rns
Copy link
Collaborator

Is it expected that some of the tests fail against OpenShift? But everything works well in the CI against K3s.

@jgwest
Copy link
Member Author

jgwest commented Mar 6, 2024

Thanks @chetan-rns!

Re: OpenShift, I ran it on a clusterbot cluster last night (rosa create 4.14) and these were the ones that failed for me:

These were the tests that failed:
    --- FAIL: TestAPISIXSuite/TestAPISIXCanarySetHeaderStep (4.52s)
    --- FAIL: TestAPISIXSuite/TestAPISIXCanarySetHeaderStep (4.57s)
    --- FAIL: TestAPISIXSuite/TestAPISIXCanarySetHeaderStep (4.65s)
    --- FAIL: TestAPISIXSuite/TestAPISIXCanarySetHeaderStep (4.67s)
    --- FAIL: TestAPISIXSuite/TestAPISIXCanarySetHeaderStep (4.79s)
    --- FAIL: TestAPISIXSuite/TestAPISIXCanarySetHeaderStep (6.37s)
    --- FAIL: TestExperimentSuite/TestExperimentWithDryRunMetrics (36.68s)
    --- FAIL: TestExperimentSuite/TestExperimentWithDryRunMetrics (36.92s)
    --- FAIL: TestExperimentSuite/TestExperimentWithDryRunMetrics (37.03s)
    --- FAIL: TestExperimentSuite/TestExperimentWithDryRunMetrics (37.51s)
    --- FAIL: TestExperimentSuite/TestExperimentWithDryRunMetrics (37.72s)
    --- FAIL: TestExperimentSuite/TestExperimentWithDryRunMetrics (38.24s)
    --- FAIL: TestFunctionalSuite/TestControllerMetrics (1.99s)
    --- FAIL: TestFunctionalSuite/TestControllerMetrics (2.01s)
    --- FAIL: TestFunctionalSuite/TestControllerMetrics (2.02s)
    --- FAIL: TestFunctionalSuite/TestControllerMetrics (2.04s)
    --- FAIL: TestFunctionalSuite/TestControllerMetrics (2.05s)

The *Metric tests fail because they expect Rollouts to be running locally to the test runner (whereas, in this case, it's running on the cluster). Not sure about the APISix test, haven't investigated it. Were these the failures you saw?

@jgwest jgwest force-pushed the improve-rollouts-e2e-test-parsing-feb-2024 branch from 00bc379 to 5934e93 Compare March 6, 2024 23:30
@jgwest jgwest merged commit 25d137a into argoproj-labs:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants