fix: use metricProviderPlugins for metrics key in configmap#131
Merged
Conversation
Signed-off-by: Jonathan West <[email protected]>
Signed-off-by: Jonathan West <[email protected]>
…or E2E Signed-off-by: Jonathan West <[email protected]>
Rizwana777
approved these changes
Feb 24, 2026
Collaborator
Rizwana777
left a comment
Rizwana777
left a comment
There was a problem hiding this comment.
LGTM, thanks Jonathan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
spec.plugins.metricfield are not correctly translated into expectedConfigMapfieldmetricPlugins, but it should bemetricProviderPlugins. See https://argo-rollouts.readthedocs.io/en/stable/analysis/plugins/Red Hat public tracker ID: https://issues.redhat.com/browse/GITOPS-9105