Skip to content

Add revision runtime parameter to LoadDataFromHub #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Add revision runtime parameter to LoadDataFromHub #928

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc4e124
Add `revision` runtime parameter
gabrielmbmb Aug 25, 2024
a069353
Lint
gabrielmbmb Aug 26, 2024
252925e
Skip `PairRM` tests
gabrielmbmb Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/distilabel/steps/generators/huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class LoadDataFromHub(GeneratorStep):
- `split`: The split of the dataset to load. Defaults to 'train'.
- `config`: The configuration of the dataset to load. This is optional and only
needed if the dataset has multiple configurations.
- `revision`: The revision of the dataset to load. Defaults to the latest revision.
- `streaming`: Whether to load the dataset in streaming mode or not. Defaults to
`False`.
- `num_examples`: The number of examples to load from the dataset.
Expand Down Expand Up @@ -122,6 +123,10 @@ class LoadDataFromHub(GeneratorStep):
description="The configuration of the dataset to load. This is optional and only"
" needed if the dataset has multiple configurations.",
)
revision: Optional[RuntimeParameter[str]] = Field(
default=None,
description="The revision of the dataset to load. Defaults to the latest revision.",
)
streaming: RuntimeParameter[bool] = Field(
default=False,
description="Whether to load the dataset in streaming mode or not. Defaults to False.",
Expand Down Expand Up @@ -149,6 +154,7 @@ def load(self) -> None:
self.repo_id, # type: ignore
self.config,
split=self.split,
revision=self.revision,
streaming=self.streaming,
)
num_examples = self._get_dataset_num_examples()
Expand Down