Skip to content

Fix bulk set #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arfeigin merged 2 commits into from
Aug 18, 2024
Merged

Fix bulk set #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
380980e
Fix bulk admin status set
stepanblyschak Aug 16, 2024
9dd9d9f
Fix incorrect buflk api usage
stepanblyschak Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions orchagent/bufferorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,9 +868,10 @@ task_process_status BufferOrch::processQueuesBulk(KeyOpFieldsValuesTuple &tuple)
}
auto queueCount = static_cast<std::uint32_t>(queueIdList.size());
std::vector<sai_status_t> statusList(queueCount, SAI_STATUS_SUCCESS);
std::vector<sai_attribute_t> attrList(queueCount, attr);

auto status = sai_queue_api->set_queues_attribute(
queueCount, queueIdList.data(), &attr,
queueCount, queueIdList.data(), attrList.data(),
SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR, statusList.data()
);

Expand Down Expand Up @@ -1275,9 +1276,10 @@ task_process_status BufferOrch::processPriorityGroupsBulk(KeyOpFieldsValuesTuple

auto pgCount = static_cast<std::uint32_t>(pgIdList.size());
std::vector<sai_status_t> statusList(pgCount, SAI_STATUS_SUCCESS);
std::vector<sai_attribute_t> attrList(pgCount, attr);

auto status = sai_buffer_api->set_ingress_priority_groups_attribute(
pgCount, pgIdList.data(), &attr,
pgCount, pgIdList.data(), attrList.data(),
SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR, statusList.data()
);

Expand Down
3 changes: 2 additions & 1 deletion orchagent/portsorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,14 +1005,15 @@ bool PortsOrch::setPortAdminStatusBulk(const std::vector<PortConfig> &portList)

auto portCount = static_cast<std::uint32_t>(portList.size());
std::vector<sai_status_t> statusList(portCount, SAI_STATUS_SUCCESS);
std::vector<sai_attribute_t> attrList(portCount, attr);
std::vector<sai_object_id_t> oidList;
for (std::uint32_t i = 0; i < portCount; i++)
{
oidList.push_back(m_portListLaneMap[portList.at(i).lanes.value]);
}

auto status = sai_port_api->set_ports_attribute(
portCount, oidList.data(), &attr,
portCount, oidList.data(), attrList.data(),
SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR, statusList.data()
);
if (status != SAI_STATUS_SUCCESS)
Expand Down