Closed
Conversation
arfeigin
changed the title
nazariig
suggested changes
Mar 27, 2024
nazariig
suggested changes
May 7, 2024
nazariig
approved these changes
May 13, 2024
arfeigin
force-pushed
the
master_validate_iface_name_length
branch
from
dbb98ff to
b197b1c
Compare
nazariig
suggested changes
Jul 2, 2024
nazariig
approved these changes
Jul 3, 2024
arfeigin
force-pushed
the
master_validate_iface_name_length
branch
from
411403a to
0126ea1
Compare
arfeigin
force-pushed
the
master_validate_iface_name_length
branch
from
0126ea1 to
f6e9494
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions.
This PR covers the cases of adding interface directly to the DB not using the cli - similar validation on the CLI side is implemented in a sonic-utilities PR.
Why I did it
Kernel restricts interface name length to not exceed IFNAMSIZ and this was not checked which can lead to inconsistency when creating such interface as it will be created in config db but it will be blocked when trying to actually create such interface.
How I verified it
Manual testing
Details if related