Skip to content

updates serpent tools dependency and pins python version#209

Merged
katyhuff merged 13 commits intomasterfrom
fix_deps
Apr 17, 2025
Merged

updates serpent tools dependency and pins python version#209
katyhuff merged 13 commits intomasterfrom
fix_deps

Conversation

@samgdotson
Copy link
Contributor

Summary of changes

This PR updates the environment.yml file by

  • pinning a version of Python that is less than 3.12
  • installing serpentTools via pip directly from GitHub, rather than PyPI.

This should fix the failing tests on GH actions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change is a source code change
    • I have added/modified tests to cover my changes
    • I have explained why my change does not require new/modified tests
  • My change is a user-facing change
    • I have recorded my changes in the changelog for the upcoming release
  • My change is exclusively related to the repository (e.g. GitHub actions workflows, PR/issue templates, etc.)
    • I have verified or justified that my change will work as intended.
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Associated Issues and PRs

  • Issue: #

Associated Developers

  • Dev: @

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@samgdotson
Copy link
Contributor Author

samgdotson commented Jan 15, 2025

@yardasol I did my best to move the needle on this... I'm not sure what testing you've done but I'm sure you're aware of the Numpy issues. I worked on it for a bit but it feels a little like whack-a-mole.

Fortunately, the error message is different. I now suspect the problem is with the installation of saltproc itself. I'm not totally sure how to tell setuptools to install a package from GitHub... I found this old documentation (which is a bit light on the documentation) suggesting something called "dependency links". But I'm not sure how much hacking you want to do with setuptools since I think it's becoming deprecated, anyway.

@yardasol
Copy link
Contributor

yardasol commented Jan 20, 2025

Thanks @samgdotson , I suspect a better solution would be to move away from setuptools to a more modern build procedure, like a pyproject.toml

@katyhuff
Copy link
Member

This seems to be failing with
ERROR: Package 'openmc' requires a different Python: 3.10.6 not in '>=3.11' Error: Process completed with exit code 1.

@samgdotson @yardasol : What do you recommend here? It seems like the python version allowed continues to cause issues.

This reverts commit 8098447.
@yardasol
Copy link
Contributor

@samgdotson I spent a couple hours chipping away at this today, and I think everything should be working now. The new changes are as follows:

  1. We have completely done away with source-building OpenMC. This was done during development of SaltProc as I needed access to the development version for the updated depletion API. That API has now since officially been released. I've pinned a minimum version of OpenMC that supports this API (0.14.0)
  2. The setup-miniconda action cannot seem to find versions of OpenMC greater than 0.13.2 when the use-only-tar-bz2 option is set to true. This option is required for caching to work properly, which was more important when we were building OpenMC from source. With a conda-build, the amount of time to spin up an environment is greatly reduced, so we can get rid of this option and most of the caching system, including the separate action for doing so which is not really needed.

Let me know your thoughts.

@samgdotson
Copy link
Contributor Author

@yardasol it’s such a relief to finally see the GH actions pass. I’m copacetic if you want to go ahead and merge it. Or if @katyhuff wants to merge since we (Olek and I) both worked on this PR.

We can address porting over to pyproject in a separate issue/PR.

@yardasol yardasol requested a review from katyhuff April 17, 2025 16:58
Copy link
Member

@katyhuff katyhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@katyhuff katyhuff merged commit a2f41fb into master Apr 17, 2025
2 checks passed
@yardasol yardasol mentioned this pull request Apr 17, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants