Fix issue with Relation column #2720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Relation column does not properly display the value of fields on *-to-one related models. When `collect()` receives an individual object (such as an Eloquent model) it will convert it to an array. However, when `Collection::wrap()` receives an individual object it wraps it in a `Collection`.
zachgarwood
added a commit
to art-institute-of-chicago/artic.edu
that referenced
this pull request
Jan 30, 2025
This was referenced Jan 30, 2025
nikhiltri
pushed a commit
to art-institute-of-chicago/artic.edu
that referenced
this pull request
Feb 6, 2025
zachgarwood
added a commit
to art-institute-of-chicago/artic.edu
that referenced
this pull request
Feb 12, 2025
zachgarwood
added a commit
to art-institute-of-chicago/artic.edu
that referenced
this pull request
Feb 13, 2025
nikhiltri
pushed a commit
to art-institute-of-chicago/artic.edu
that referenced
this pull request
Feb 13, 2025
ifox
approved these changes
Mar 11, 2025
nikhiltri
pushed a commit
to art-institute-of-chicago/artic.edu
that referenced
this pull request
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Relation column does not properly display the value of fields on *-to-one related models. When
collect()receives an individual object (such as an Eloquent model) it will convert it to aCollection. However, whenCollection::wrap()receives an individual object it wraps it in aCollection, which is the desired behavior.Related Issues
Fixes #2719
Fixes #2682