Don't load relation for each column and allow dot notation in field name for index table #2603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can eager load attributes using
eagerLoadListingRelations([])in thesetUpof the controller, however theRelationcolumn doesn't actually use the loaded relation (and doesn't work with one to one relation) it currently runs a query for each column and each model and the defaultTextalso cannot use it because it does not use dot notation traversalThis PR aims to greatly improve this by only loading the relation once and allowing dot notation in text column to allow to retrieve fields in one to one relations or json