Fix dbal 4 conflict #2596
Merged
Fix dbal 4 conflict #2596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤷 I'll need to add rules for Laravel 9 to continue using dbal 3. On that later today and will release 3.3.1 right after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow dbal 4 to be installed to prevent conflicts when installing Twill. FWIW, deleting the
composer.lockfile before installing Twill doesn't currently produce any conflict, but we of course want a clean install in any Laravel app, so we're adding dbal 4.0 even though we don't need it anymore in Twill due to Laravel itself not needing it anymore since Laravel 11. It would be a breaking change to drop it for now, so we'll do that in Twill 4.Fixes #2594