Skip to content

Make twillTrans exportable so it can be used in config #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2024
Merged

Make twillTrans exportable so it can be used in config #2563

merged 4 commits into from
May 23, 2024

Conversation

@Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Mar 28, 2024

Currently if you use twillTrans in a config file and run php artisan config:cache the command will fail because TwillTranslation does not implement the required __set_state method to work in var_export

This PR adds the method so that config:cache can work with twillTrans

@ifox ifox merged commit c1aff40 into area17:3.x May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ifox ifox ifox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tofandel @ifox