Disable heading extension if it's not in the toolbar #2511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thank you a lot @Tofandel! |
|
Can you merge this @Tofandel? |
|
@Tofandel doesn't have merge permissions on this repository. We're working on Twill 3.3 with Laravel 11 support and this PR and many other will be included. |
|
Wow, thanks @ifox, any eta for 3.3? We are trying to decide if we should fork this project or just wait for 3.3, so eta would be super helpful for our planning. |
|
I already forked it with all my PR's if you want to use my branch until then, you can override in composer with my 3.x branch |
ifox
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since tiptap still allows html based on the extensions configured, if we disallow headings we need to let the extension know as well that it shouldn't load
Fixes #2489