Skip to content

Conversation

@zeezo887
Copy link
Collaborator

Description

This PR overrides the base TableColumn class getKey() to prepend the browser's name to the browser key.

public function getKey(): string
    {
        if ($this->key === null) {
            throw new ColumnMissingPropertyException();
        }

        if (null === $this->browser) {
            throw new ColumnMissingPropertyException('Browser column missing browser value: ' . $this->field);
        }

        return "$this->browser.$this->key";
    }

Related Issues

Fixes #2284

@Tofandel
Copy link
Contributor

Isn't it possible for two browsers to also have the same name?

@zeezo887
Copy link
Collaborator Author

Browsers can use the same module, but cannot have the same name within the same form.

@ifox ifox merged commit 7f1035d into area17:3.x May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table builder Browser column overrides parent module field

3 participants