Skip to content

Conversation

@Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Feb 26, 2024

Description

It's very much possible to implement an Image column with a custom thumbnail (eg coming from youtube or any other service)

Right now the following throws an exception if the Video model doesn't use HasMedias

            Image::make()->field('thumbnail')->title('Thumbnail')
                ->customRender(fn(Video $video) => $video->getThumbnail(80, 80))

But it shouldn't because of the custom render method provided

BTW I noticed a related issue on the browser, using any other field name than thumbnail on image in the browser columns results in the image being displayed as text instead of as an image as well as the order of the columns being wrong

@ifox ifox merged commit 057554a into area17:3.x Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants