Constructor with parameters for ValidationError and ValidationError.Create

[jeangatto]

Hi! I was thinking of improving the approach by initializing the ValidationError class.

Instead of:

if (await _repository.ExistsAsync(request.Email))
{
    return Result.Invalid(new List<ValidationError>
    {
        new ValidationError
        {
            ErrorMessage = "The email address provided is already in use"
        }
    });
}

To do this:

if (await _repository.ExistsAsync(request.Email))
{
    return Result.Invalid(ValidationError.Create(new ValidationError(""));
}

public class ValidationError
{
    public ValidationError(string errorMessage)
    {
        ErrorMessage = errorMessage;
    }

    public ValidationError(string identifier, string errorMessage, string errorCode, ValidationSeverity severity)
    {
        Identifier = identifier;
        ErrorMessage = errorMessage;
        ErrorCode = errorCode;
        Severity = severity;
    }

    public ValidationError()
    {
    }

    public string Identifier { get; set; }

    public string ErrorMessage { get; set; }

    public string ErrorCode { get; set; }

    public ValidationSeverity Severity { get; set; }

    public static IList<ValidationError> Create(params ValidationError[] errors) => new List<ValidationError>(errors);
}

[danihengeveld]

I propose adding the following overload public static Result.Invalid(params ValidationError[] validationErrors){ ... }. So directly in the Result type instead of a factory method on ValidationError. I think this is more consistent with the rest of the methods.

The extra constructors I can get behind. Because new ValidationError("Name is required") is more concise as new ValidationError { ErrorMessage = "Name is required" } in my opinion.

I'll open a PR for it.