Skip to content

Frontend audit: refinements#2083

Merged
dartpain merged 9 commits intoarc53:mainfrom
ManishMadan2882:main
Oct 22, 2025
Merged

Frontend audit: refinements#2083
dartpain merged 9 commits intoarc53:mainfrom
ManishMadan2882:main

Conversation

@ManishMadan2882
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 commented Oct 20, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    1. Fix: failed attachments close button was non-functional; separated id and task id; id is used for state management operations
    2. When the upload modal and upload toast where open; on clicking at the toast the modal was closed( stopped event propagation on toast click and mousedown)
    3. The no files icon in the Tools popup was incorrect for the light theme
    4. Agents Preview: Scroll is on the agent configuration only, the preview remains fixed
    5. Fixed the dropdown options in share conversation modal (Source selection dropdown)
    6. added some missing i18n keys
  • Why was this change needed? (You can also link to an open issue here)
    UI/UX
  • Other information:
Screenshot from 2025-10-17 03-49-18

@vercel
Copy link

vercel bot commented Oct 20, 2025

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.21%. Comparing base (498e2b7) to head (6eb77c4).
⚠️ Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
+ Coverage   34.67%   42.21%   +7.53%     
==========================================
  Files         131      135       +4     
  Lines        8703     9303     +600     
==========================================
+ Hits         3018     3927     +909     
+ Misses       5685     5376     -309     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dartpain dartpain merged commit c4e8daf into arc53:main Oct 22, 2025
7 of 9 checks passed
@Pranavi125

This comment was marked as spam.

@dartpain
Copy link
Contributor

@Pranavi125 Please dont comment on already merged issues unless its relevant to them. I see that you left many comments on our open issue, please refrain leaving more unless they are relevant. Please check out https://github.com/arc53/DocsGPT/blob/main/CONTRIBUTING.md

I am impressed by your enthusiasm, but this is a warning, if messages that are not relevant continue I may have to block your account temporarily from our repo's.

Thank you!

ManishMadan2882 added a commit to aqsaaqeel/DocsGPT that referenced this pull request Oct 30, 2025
* (fix:attachements) sep id for redux ops

* (fix:ui) popups, toast, share modal

* (feat:agentsPreview) stable preview, ui fixes

* (fix:ui) light theme icon, sleek scroll

---------

Co-authored-by: GH Action - Upstream Sync <[email protected]>
ManishMadan2882 added a commit that referenced this pull request Feb 16, 2026
* (fix:attachements) sep id for redux ops

* (fix:ui) popups, toast, share modal

* (feat:agentsPreview) stable preview, ui fixes

* (fix:ui) light theme icon, sleek scroll

---------

Co-authored-by: GH Action - Upstream Sync <[email protected]>
ManishMadan2882 added a commit that referenced this pull request Feb 16, 2026
* (fix:attachements) sep id for redux ops

* (fix:ui) popups, toast, share modal

* (feat:agentsPreview) stable preview, ui fixes

* (fix:ui) light theme icon, sleek scroll

---------

Co-authored-by: GH Action - Upstream Sync <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants