Skip to content

fix(nodejs): fix npmjs parser.pkgNameFromPath() panic issue #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DmitriyLewen merged 5 commits into from
Oct 23, 2025
Merged

fix(nodejs): fix npmjs parser.pkgNameFromPath() panic issue #9688

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9c0ebb
fix(npm-panic): fix npm parser panic issue
derekhjray Oct 20, 2025
6e0ae74
Update pkg/dependency/parser/nodejs/npm/parse_test.go
derekhjray Oct 23, 2025
62fe48a
refactor: use strings.TrimPrefix for `/`
DmitriyLewen Oct 23, 2025
98d6f86
Merge branch 'main' of github.com:aquasecurity/trivy into derekhjray/…
DmitriyLewen Oct 23, 2025
79c8559
fix: linter error
DmitriyLewen Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/dependency/parser/nodejs/npm/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,10 @@ func (p *Parser) pkgNameFromPath(pkgPath string) string {
// node_modules/function1
// node_modules/nested_func/node_modules/debug
if index := strings.LastIndex(pkgPath, nodeModulesDir); index != -1 {
if index+len(nodeModulesDir) == len(pkgPath) {
return ""
}

Copy link
Contributor

@DmitriyLewen DmitriyLewen Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a warning here since the package-lock.json file is invalid in this case?

Copy link
Contributor Author

@derekhjray derekhjray Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you could add warning message to warn the lock file is malformed

return pkgPath[index+len(nodeModulesDir)+1:]
}
p.logger.Warn("Package path doesn't have `node_modules` prefix", log.String("pkg_path", pkgPath))
Expand Down
36 changes: 36 additions & 0 deletions pkg/dependency/parser/nodejs/npm/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,39 @@ func TestParse(t *testing.T) {
})
}
}

func TestPkgNameFromPath(t *testing.T) {
tests := []struct {
path string
expected string
}{
{
path: "node_modules/package-name",
expected: "package-name",
},
{
path: "node_modules/package-name/sub-package",
expected: "package-name/sub-package",
},
{
path: "node_modules/package-name/node_modules/sub-sub-package",
expected: "sub-sub-package",
},
{
path: "node_modules",
expected: "",
},
{
path: "node_modules/",
expected: "",
},
}

parser := &Parser{}
for _, test := range tests {
t.Run(test.path, func(t *testing.T) {
path := parser.pkgNameFromPath(test.path)
assert.Equal(t, path, test.expected)
})
}
}