Skip to content

fix(k8s): disable parallel traversal with fs cache for k8s images #9534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 30, 2025
Merged

fix(k8s): disable parallel traversal with fs cache for k8s images #9534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2344a8a
chore: up the PR
afdesk Sep 29, 2025
d6632e6
test(k8s): add specific counts for itests
afdesk Sep 29, 2025
740fa94
chore(test): use a specific KinD image for itests
afdesk Sep 29, 2025
3fd845b
fix: don't use parallel for fs cache
afdesk Sep 29, 2025
8163d8c
chore(test): use kind node v1.27.1 for itests
afdesk Sep 29, 2025
4e03d08
chore: update golden file based on limited envs
afdesk Sep 29, 2025
55299c4
chore: update comments
afdesk Sep 29, 2025
6d47c92
test(k8s): keep IDs in the golden file
afdesk Sep 29, 2025
50791de
chore: remove unused flag
afdesk Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 52 additions & 19 deletions integration/k8s_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"encoding/json"
"os"
"path/filepath"
"sort"
"testing"

cdx "github.com/CycloneDX/cyclonedx-go"
Expand All @@ -28,19 +29,14 @@ func TestK8s(t *testing.T) {
outputFile := filepath.Join(t.TempDir(), "output.json")

osArgs := []string{
"--cache-dir",
cacheDir,
"--cache-dir", cacheDir,
"k8s",
"kind-kind-test",
"--report",
"summary",
"--report", "summary",
"-q",
"--timeout",
"5m0s",
"--format",
"json",
"--output",
outputFile,
"--timeout", "5m0s",
"--format", "json",
"--output", outputFile,
}

// Run Trivy
Expand All @@ -60,15 +56,47 @@ func TestK8s(t *testing.T) {
return resource.Results
})

// Has vulnerabilities
assert.True(t, lo.SomeBy(results, func(r types.Result) bool {
return len(r.Vulnerabilities) > 0
}))
// Collect IDs (CVEs for vulns, IDs for failed misconfigs), allowing duplicates.
ids := k8sFindingIDs{}
for _, r := range results {
for _, v := range r.Vulnerabilities {
if v.VulnerabilityID != "" {
ids.Vulnerabilities = append(ids.Vulnerabilities, v.VulnerabilityID)
}
}
for _, m := range r.Misconfigurations {
if m.Status == types.MisconfStatusFailure && m.ID != "" {
ids.Misconfigurations = append(ids.Misconfigurations, m.ID)
}
}
}

// Has misconfigurations
assert.True(t, lo.SomeBy(results, func(r types.Result) bool {
return len(r.Misconfigurations) > 0
}))
// Sort for deterministic golden files
sort.Strings(ids.Vulnerabilities)
sort.Strings(ids.Misconfigurations)

fixture := filepath.Join("testdata", "fixtures", "k8s", "summary-ids.json.golden")
if *update {
// Update fixture with current IDs (duplicates kept, sorted)
// Note: mage test:k8s may create additional k8s artifacts.
f, err := os.Create(fixture)
require.NoError(t, err)
defer f.Close()
enc := json.NewEncoder(f)
enc.SetIndent("", " ")
require.NoError(t, enc.Encode(ids))
t.Logf("updated fixture: %s", fixture)
return
}

// Read expected IDs from fixture and compare
ef, err := os.Open(fixture)
require.NoError(t, err)
defer ef.Close()

var want k8sFindingIDs
require.NoError(t, json.NewDecoder(ef).Decode(&want))
assert.Equal(t, want, ids)
})
t.Run("kbom cycloneDx", func(t *testing.T) {
// Set up the output file
Expand Down Expand Up @@ -106,7 +134,6 @@ func TestK8s(t *testing.T) {
return len(*r.Dependencies) > 0
}))
})

t.Run("limited user test", func(t *testing.T) {
// Set up the output file
outputFile := filepath.Join(t.TempDir(), "output.json")
Expand Down Expand Up @@ -158,3 +185,9 @@ func TestK8s(t *testing.T) {

})
}

// k8sFindingIDs is the structure saved into the golden file.
type k8sFindingIDs struct {
Vulnerabilities []string `json:"vulnerabilities"`
Misconfigurations []string `json:"misconfigurations"`
}
290 changes: 290 additions & 0 deletions integration/testdata/fixtures/k8s/summary-ids.json.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,290 @@
{
"vulnerabilities": [
"CVE-2019-1551",
"CVE-2019-1551",
"CVE-2019-1563",
"CVE-2019-1563",
"CVE-2019-18276",
"CVE-2019-18276",
"CVE-2019-5094",
"CVE-2019-5094",
"CVE-2019-5094",
"CVE-2019-5094",
"CVE-2019-5094",
"CVE-2019-5094",
"CVE-2019-5094",
"CVE-2019-5094"
],
"misconfigurations": [
"AVD-KSV-01010",
"KCV0001",
"KCV0006",
"KCV0010",
"KCV0018",
"KCV0019",
"KCV0020",
"KCV0021",
"KCV0022",
"KCV0030",
"KCV0033",
"KCV0038",
"KCV0059",
"KCV0069",
"KCV0075",
"KCV0077",
"KSV001",
"KSV001",
"KSV001",
"KSV001",
"KSV001",
"KSV001",
"KSV001",
"KSV001",
"KSV001",
"KSV0012",
"KSV003",
"KSV003",
"KSV003",
"KSV003",
"KSV003",
"KSV003",
"KSV003",
"KSV003",
"KSV003",
"KSV004",
"KSV004",
"KSV004",
"KSV004",
"KSV004",
"KSV004",
"KSV004",
"KSV004",
"KSV004",
"KSV009",
"KSV009",
"KSV009",
"KSV009",
"KSV009",
"KSV009",
"KSV011",
"KSV011",
"KSV011",
"KSV011",
"KSV011",
"KSV011",
"KSV011",
"KSV011",
"KSV011",
"KSV012",
"KSV012",
"KSV012",
"KSV012",
"KSV012",
"KSV012",
"KSV012",
"KSV012",
"KSV012",
"KSV012",
"KSV0125",
"KSV0125",
"KSV0125",
"KSV0125",
"KSV0125",
"KSV0125",
"KSV0125",
"KSV0125",
"KSV014",
"KSV014",
"KSV014",
"KSV014",
"KSV014",
"KSV014",
"KSV014",
"KSV014",
"KSV014",
"KSV015",
"KSV015",
"KSV015",
"KSV015",
"KSV016",
"KSV016",
"KSV016",
"KSV016",
"KSV016",
"KSV016",
"KSV016",
"KSV017",
"KSV018",
"KSV018",
"KSV018",
"KSV018",
"KSV018",
"KSV018",
"KSV018",
"KSV018",
"KSV020",
"KSV020",
"KSV020",
"KSV020",
"KSV020",
"KSV020",
"KSV020",
"KSV020",
"KSV020",
"KSV020",
"KSV021",
"KSV021",
"KSV021",
"KSV021",
"KSV021",
"KSV021",
"KSV021",
"KSV021",
"KSV021",
"KSV021",
"KSV022",
"KSV022",
"KSV023",
"KSV023",
"KSV023",
"KSV023",
"KSV023",
"KSV023",
"KSV030",
"KSV030",
"KSV030",
"KSV030",
"KSV030",
"KSV030",
"KSV036",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV041",
"KSV044",
"KSV045",
"KSV046",
"KSV046",
"KSV046",
"KSV046",
"KSV046",
"KSV046",
"KSV046",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV048",
"KSV049",
"KSV049",
"KSV049",
"KSV049",
"KSV049",
"KSV049",
"KSV049",
"KSV049",
"KSV050",
"KSV050",
"KSV053",
"KSV053",
"KSV053",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV056",
"KSV104",
"KSV104",
"KSV104",
"KSV104",
"KSV104",
"KSV104",
"KSV106",
"KSV106",
"KSV106",
"KSV106",
"KSV106",
"KSV106",
"KSV106",
"KSV106",
"KSV106",
"KSV110",
"KSV111",
"KSV112",
"KSV112",
"KSV113",
"KSV113",
"KSV117",
"KSV117",
"KSV117",
"KSV118",
"KSV118",
"KSV118",
"KSV118",
"KSV118",
"KSV118",
"KSV118",
"KSV118",
"KSV118",
"KSV119",
"KSV122",
"no-user-pods-in-system-namespace",
"no-user-pods-in-system-namespace",
"no-user-pods-in-system-namespace",
"no-user-pods-in-system-namespace"
]
}
Loading
Loading