Conversation
jandom
added
the
safe-to-test
| -v ${{ github.workspace }}:/opt/openfold3 \ | ||
| ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:test-${{ inputs.cuda_base_image_tag }}-${{ github.sha }} \ | ||
| pytest openfold3/tests -vvv | ||
| pytest openfold3/tests -vvv -n auto --cov=openfold3 --cov-report=xml |
There was a problem hiding this comment.
This could be baked into pyproject.toml but I like it more opt-in and explicit this way (at least for now)
|
Maybe we should consider adding also pytest-benchmark? As a note, there are some changes (hopefully improvements) to pyproject.toml in the modernize-conda PR: I am fearing a bit the next rebase once further changes to pyproject.toml are merged into main, but that is my bad for having such a long-lived branch. |
|
100% let's add 'pytest-benchmark' in – it'll guard us against things becoming silently ungodly slow! Yeah, I'm treading carefully around pyproject.toml because I know your PR is coming ;-) |
jnwei
left a comment
jnwei
left a comment
There was a problem hiding this comment.
LGTM! could you also report the current code coverage so we know where we're starting from?
3 participants
Summary
This will help my test writing efforts tremendously: adding an ability to generate coverage reports, and, running tests in parallel
Changes
Added pytest-cov and pytest-xdist as test-only deps
Related Issues
Testing
Other Notes