feat: docker image for SandboxAQ/aqaffinity#102
Conversation
jnwei
left a comment
There was a problem hiding this comment.
LGTM, but maybe this would be a PR better suited for the Sandbox AQ affinity repo itself?
Two small comments:
- Could you mention the system that you tested this docker image on?
- I have a suggestion regarding the example file naming, see in comment in line.
There was a problem hiding this comment.
Can we reuse any of the existing examples?
The current file name query_single_protein_ligand_affinity.json suggests to me that there is a difference between the inputs required for affinity prediction vs the inputs for openfold3 inference. From a glance, it doesn't look like there are any additional input fields required for the affinity modle.
If we want a simpler protein/ ligand filename, perhaps we could name the example file query_single_protein_single_ligand.json?
There was a problem hiding this comment.
Correct, and i was surprised by that too – it only works on single-chain, single-ligand complexes. None of the examples, as far as I could see, had that.
We should probably document that behavior somewhere.
+1 to simpler filename, yeah
There was a problem hiding this comment.
Updated the filename now
Thanks for the review, really good as always 🙌 Updated the PR description above (it was g5.xlarge) |
Summary
Here is the experimental build I did on an AWS g5.xlarge with the deep learning AMI as base image.
Requires to be logged into hugging face cli locally, to clone the repo at image build. Confirm login with
Build with
Run with
And then the output will be in
Changes
Related Issues
Testing
Other Notes