Skip to content

Conversation

@runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Jul 23, 2025

Description

Fixed the unwrap bug when breakpoint was hit by a function.

Added ability to:

  1. Step over n instructions, which would treat call/call generic instruction as a single step and don't break on the function bodies of the callee function.
  2. Step n instructions.
  3. Step out from the current function

How Has This Been Tested?

Manually tested via aptos cli.

Key Areas to Review

N/A

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@runtian-zhou runtian-zhou force-pushed the runtianz/fix_breakpoint branch from 5827dc7 to a0e1807 Compare July 28, 2025 16:56
@runtian-zhou runtian-zhou force-pushed the runtianz/fix_breakpoint branch from a0e1807 to 72007dd Compare July 28, 2025 17:28
@runtian-zhou runtian-zhou marked this pull request as ready for review July 28, 2025 18:02
@runtian-zhou runtian-zhou force-pushed the runtianz/fix_breakpoint branch from 72007dd to 5750486 Compare July 28, 2025 18:02
@runtian-zhou runtian-zhou enabled auto-merge (squash) July 29, 2025 17:48
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 5750486f63f3b6aa207db720d73478658ac44149

Compatibility test results for 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 5750486f63f3b6aa207db720d73478658ac44149 (PR)
1. Check liveness of validators at old version: 8e7acd6f8692b1bf870e8232cb95eab97ab5b270
compatibility::simple-validator-upgrade::liveness-check : committed: 6413.53 txn/s, latency: 4960.32 ms, (p50: 4300 ms, p70: 4600, p90: 11200 ms, p99: 13100 ms), latency samples: 258560
2. Upgrading first Validator to new version: 5750486f63f3b6aa207db720d73478658ac44149
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2509.84 txn/s, latency: 13445.41 ms, (p50: 14800 ms, p70: 15400, p90: 15700 ms, p99: 15800 ms), latency samples: 94120
3. Upgrading rest of first batch to new version: 5750486f63f3b6aa207db720d73478658ac44149
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2467.39 txn/s, latency: 13594.28 ms, (p50: 15000 ms, p70: 15500, p90: 15900 ms, p99: 16000 ms), latency samples: 93240
4. upgrading second batch to new version: 5750486f63f3b6aa207db720d73478658ac44149
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4345.79 txn/s, latency: 7840.41 ms, (p50: 8600 ms, p70: 9000, p90: 9500 ms, p99: 9600 ms), latency samples: 152500
5. check swarm health
Compatibility test for 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 5750486f63f3b6aa207db720d73478658ac44149 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 5750486f63f3b6aa207db720d73478658ac44149

two traffics test: inner traffic : committed: 11483.78 txn/s, submitted: 11483.83 txn/s, expired: 0.05 txn/s, latency: 3282.12 ms, (p50: 3200 ms, p70: 3300, p90: 3600 ms, p99: 4200 ms), latency samples: 4366400
two traffics test : committed: 99.96 txn/s, latency: 962.68 ms, (p50: 800 ms, p70: 900, p90: 1200 ms, p99: 4600 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.603, avg: 2.511", "ConsensusProposalToOrdered: max: 0.166, avg: 0.163", "ConsensusOrderedToCommit: max: 0.296, avg: 0.218", "ConsensusProposalToCommit: max: 0.458, avg: 0.381"]
Max non-epoch-change gap was: 2 rounds at version 2086262 (avg 0.00) [limit 4], 2.34s no progress at version 2086262 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.34s no progress at version 2044091 (avg 0.34s) [limit 16].
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 5750486f63f3b6aa207db720d73478658ac44149

Compatibility test results for 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 5750486f63f3b6aa207db720d73478658ac44149 (PR)
Upgrade the nodes to version: 5750486f63f3b6aa207db720d73478658ac44149
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1682.90 txn/s, submitted: 1687.35 txn/s, failed submission: 4.45 txn/s, expired: 4.45 txn/s, latency: 1766.31 ms, (p50: 1700 ms, p70: 1800, p90: 2400 ms, p99: 3700 ms), latency samples: 151261
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1642.34 txn/s, submitted: 1648.51 txn/s, failed submission: 6.17 txn/s, expired: 6.17 txn/s, latency: 1861.14 ms, (p50: 1800 ms, p70: 2100, p90: 2400 ms, p99: 3700 ms), latency samples: 149162
5. check swarm health
Compatibility test for 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 5750486f63f3b6aa207db720d73478658ac44149 passed
Upgrade the remaining nodes to version: 5750486f63f3b6aa207db720d73478658ac44149
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1744.69 txn/s, submitted: 1750.19 txn/s, failed submission: 5.50 txn/s, expired: 5.50 txn/s, latency: 1765.83 ms, (p50: 1800 ms, p70: 1800, p90: 2100 ms, p99: 3300 ms), latency samples: 152260
Test Ok

@runtian-zhou runtian-zhou merged commit ba8eeeb into main Jul 29, 2025
88 of 89 checks passed
@runtian-zhou runtian-zhou deleted the runtianz/fix_breakpoint branch July 29, 2025 18:32
fengjy73 pushed a commit to fengjy73/aptos-core that referenced this pull request Aug 20, 2025
faculerena pushed a commit to CoinFabrik/aptos-core that referenced this pull request Aug 25, 2025
jgcrosta pushed a commit to CoinFabrik/aptos-core that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants