Skip to content

fix: various lighthouse issues #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TorstenDittmann merged 3 commits into from
Oct 2, 2023
Merged

fix: various lighthouse issues #156

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d583aa3
fix: various lighthouse issues
TorstenDittmann Oct 2, 2023
1c454b8
chore: try pre-compress node
TorstenDittmann Oct 2, 2023
16a769a
Apply suggestions from code review
TorstenDittmann Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/components/FooterNav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</script>

<nav class="aw-footer-nav u-margin-block-start-100 u-position-relative aw-u-sep-block-start">
<img class="aw-logo" src="/images/logos/appwrite.svg" alt="appwrite" width="130" />
<img class="aw-logo" src="/images/logos/appwrite.svg" alt="appwrite" height="24" width="130" />
<ul class="aw-footer-nav-main-list">
<li class="aw-footer-nav-main-item">
<h5 class="aw-footer-nav-main-title aw-is-not-mobile aw-caption-500 aw-eyebrow">
Expand Down
8 changes: 4 additions & 4 deletions src/lib/layouts/Docs.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@
class="aw-logo u-only-dark"
src="/images/logos/appwrite.svg"
alt="appwrite"
width="130"
height="24" width="130"
/>
<img
class="aw-logo u-only-light"
src="/images/logos/appwrite-light.svg"
alt="appwrite"
width="130"
height="24" width="130"
/>
</a>
</div>
Expand Down Expand Up @@ -114,13 +114,13 @@
class="aw-logo u-only-dark"
src="/images/logos/appwrite.svg"
alt="appwrite"
width="130"
height="24" width="130"
/>
<img
class="aw-logo u-only-light"
src="/images/logos/appwrite-light.svg"
alt="appwrite"
width="130"
height="24" width="130"
/>
</a>
<nav class="aw-main-header-nav">
Expand Down
8 changes: 4 additions & 4 deletions src/lib/layouts/Main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,13 @@
class="aw-logo aw-u-only-dark"
src="/images/logos/appwrite.svg"
alt="appwrite"
width="130"
height="24" width="130"
/>
<img
class="aw-logo aw-u-only-light"
src="/images/logos/appwrite-light.svg"
alt="appwrite"
width="130"
height="24" width="130"
/>
</a>
</div>
Expand Down Expand Up @@ -177,13 +177,13 @@
class="aw-logo aw-u-only-dark"
src="/images/logos/appwrite.svg"
alt="appwrite"
width="130"
height="24" width="130"
/>
<img
class="aw-logo aw-u-only-light"
src="/images/logos/appwrite-light.svg"
alt="appwrite"
width="130"
height="24" width="130"
/>
</a>
<nav class="aw-main-header-nav">
Expand Down
26 changes: 17 additions & 9 deletions src/markdoc/tags/Icon_Image.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
<script lang="ts">
export let src: string;
export let alt: string;
export let size: string = 's';
export let src: string;
export let alt: string;
export let size: string = 's';

const sizes: Record<string, string> = {
s: '16px',
const sizes: Record<string, string> = {
s: '16px',
m: '20px',
l: '32px',
xl: '40px'
};
l: '32px',
xl: '40px'
};
</script>

<img {src} {alt} loading="lazy" style:width={sizes[size]} style:vertical-align="middle" />
<img
{src}
{alt}
loading="lazy"
width={sizes[size]}
height={sizes[size]}
style:width={sizes[size]}
style:vertical-align="middle"
/>
1 change: 1 addition & 0 deletions src/routes/+layout.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const prerender = true;
1 change: 0 additions & 1 deletion src/routes/+layout.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/scss/1-css-variables/_fonts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use '../abstract' as *;
:root {
--aw-font-family-aeonik-pro: 'Aeonik Pro', 'Poppins', arial, sans-serif;
--aw-font-family-aeonik-pro: 'Aeonik Pro', arial, sans-serif;
--aw-font-family-inter: 'Inter', arial, sans-serif;
--aw-font-family-aeonik-fono: 'Aenoik Fono', monospace;
}
Expand Down
7 changes: 7 additions & 0 deletions src/scss/3-fonts/_aeonik-fono.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,47 +3,54 @@
font-family: 'Aenoik Fono';
font-style: normal;
font-weight: 100;
font-display: swap;
src: local('Aeonik Fono'), local('AeonikFono'), url('/fonts/aeonik-fono/AeonikFono-Air.woff2') format('woff2');
}

@font-face {
font-family: 'Aenoik Fono';
font-style: normal;
font-weight: 200;
font-display: swap;
src: local('Aeonik Fono'), local('AeonikFono'), url('/fonts/aeonik-fono/AeonikFono-Thin.woff2') format('woff2');
}

@font-face {
font-family: 'Aenoik Fono';
font-style: normal;
font-weight: 300;
font-display: swap;
src: local('Aeonik Fono'), local('AeonikFono'), url('/fonts/aeonik-fono/AeonikFono-Light.woff2') format('woff2');
}

@font-face {
font-family: 'Aenoik Fono';
font-style: normal;
font-weight: 400;
font-display: swap;
src: local('Aeonik Fono'), local('AeonikFono'), url('/fonts/aeonik-fono/AeonikFono-Regular.woff2') format('woff2');
}

@font-face {
font-family: 'Aenoik Fono';
font-style: normal;
font-weight: 500;
font-display: swap;
src: local('Aeonik Fono'), local('AeonikFono'), url('/fonts/aeonik-fono/AeonikFono-Medium.woff2') format('woff2');
}

@font-face {
font-family: 'Aenoik Fono';
font-style: normal;
font-weight: 600;
font-display: swap;
src: local('Aeonik Fono'), local('AeonikFono'), url('/fonts/aeonik-fono/AeonikFono-Bold.woff2') format('woff2');
}

@font-face {
font-family: 'Aenoik Fono';
font-style: normal;
font-weight: 700;
font-display: swap;
src: local('Aeonik Fono'), local('AeonikFono'), url('/fonts/aeonik-fono/AeonikFono-Black.woff2') format('woff2');
}
15 changes: 14 additions & 1 deletion src/scss/3-fonts/_aeonik-pro.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,98 +4,111 @@
font-family: 'Aeonik Pro';
font-style: normal;
font-weight: 100;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-Air.woff2') format('woff2');
}

@font-face {
font-family: 'Aeonik Pro';
font-style: italic;
font-weight: 100;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-AirItalic.woff2') format('woff2');
}
///
@font-face {
font-family: 'Aeonik Pro';
font-style: normal;
font-weight: 200;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-Thin.woff2') format('woff2');
}

@font-face {
font-family: 'Aeonik Pro';
font-style: italic;
font-weight: 200;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-ThinItalic.woff2') format('woff2');
}
///
///
@font-face {
font-family: 'Aeonik Pro';
font-style: normal;
font-weight: 300;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-Light.woff2') format('woff2');
}

@font-face {
font-family: 'Aeonik Pro';
font-style: italic;
font-weight: 300;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-LightItalic.woff2') format('woff2');
}
///
@font-face {
font-family: 'Aeonik Pro';
font-style: normal;
font-weight: 400;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-Regular.woff2') format('woff2');
}

@font-face {
font-family: 'Aeonik Pro';
font-style: italic;
font-weight: 400;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-RegularItalic.woff2') format('woff2');
}
///
@font-face {
font-family: 'Aeonik Pro';
font-style: normal;
font-weight: 500;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-Medium.woff2') format('woff2');
}

@font-face {
font-family: 'Aeonik Pro';
font-style: italic;
font-weight: 500;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-MediumItalic.woff2') format('woff2');
}
///
@font-face {
font-family: 'Aeonik Pro';
font-style: normal;
font-weight: 600;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-Bold.woff2') format('woff2');
}

@font-face {
font-family: 'Aeonik Pro';
font-style: italic;
font-weight: 600;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-BoldItalic.woff2') format('woff2');
}
///
@font-face {
font-family: 'Aeonik Pro';
font-style: normal;
font-weight: 700;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-Black.woff2') format('woff2');
}

@font-face {
font-family: 'Aeonik Pro';
font-style: italic;
font-weight: 700;
font-display: swap;
src: local('Aeonik Pro'), local('AeonikPro'), url('/fonts/aeonik-pro/AeonikPro-BlackItalic.woff2') format('woff2');
}
///
9 changes: 9 additions & 0 deletions src/scss/3-fonts/_inter.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,53 +4,62 @@
font-family: 'Inter';
font-style: normal;
font-weight: 100;
font-display: swap;
src: url('/fonts/inter/inter-latin-100-normal.woff2') format('woff2');
}
@font-face {
font-family: 'Inter';
font-style: normal;
font-weight: 200;
font-display: swap;
src: url('/fonts/inter/inter-latin-200-normal.woff2') format('woff2');
}
@font-face {
font-family: 'Inter';
font-style: normal;
font-weight: 300;
font-display: swap;
src: url('/fonts/inter/inter-latin-300-normal.woff2') format('woff2');
}
@font-face {
font-family: 'Inter';
font-style: normal;
font-weight: 400;
font-display: swap;
src: url('/fonts/inter/inter-latin-400-normal.woff2') format('woff2');
}
@font-face {
font-family: 'Inter';
font-style: normal;
font-weight: 500;
font-display: swap;
src: url('/fonts/inter/inter-latin-500-normal.woff2') format('woff2');
}
@font-face {
font-family: 'Inter';
font-style: normal;
font-weight: 600;
font-display: swap;
src: url('/fonts/inter/inter-latin-600-normal.woff2') format('woff2');
}
@font-face {
font-family: 'Inter';
font-style: normal;
font-weight: 700;
font-display: swap;
src: url('/fonts/inter/inter-latin-700-normal.woff2') format('woff2');
}
@font-face {
font-family: 'Inter';
font-style: normal;
font-weight: 800;
font-display: swap;
src: url('/fonts/inter/inter-latin-800-normal.woff2') format('woff2');
}
@font-face {
font-family: 'Inter';
font-style: normal;
font-weight: 900;
font-display: swap;
src: url('/fonts/inter/inter-latin-900-normal.woff2') format('woff2');
}
6 changes: 3 additions & 3 deletions src/scss/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
@include meta.load-css('2-resets');
}

@layer fonts {
@include meta.load-css('3-fonts');
}
// @layer fonts {
// @include meta.load-css('3-fonts');
// }
Comment thread
TorstenDittmann marked this conversation as resolved.
Outdated

@layer icons {
@include meta.load-css('4-icons');
Expand Down
4 changes: 3 additions & 1 deletion svelte.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ function absoulute(path) {

const isVercel = process.env.VERCEL === '1';

const adapter = isVercel ? staticAdapter() : nodeAdapter();
const adapter = isVercel ? staticAdapter() : nodeAdapter({
precompress: true
});
Comment thread
TorstenDittmann marked this conversation as resolved.
Outdated

/** @type {import('@sveltejs/kit').Config}*/
const config = {
Expand Down